[ty] ty_ide: Hotfix for expression_scope_id panics#18455
Merged
Conversation
Fixes #572 Co-authored-by: Andrew Gallant <andrew@astral.sh>
sharkdp
requested review from
AlexWaygood,
MichaReiser and
dcreager
as code owners
Contributor
|
carljm
reviewed
Jun 4, 2025
| ast::AnyNodeRef::Identifier(identifier) => index.expression_scope_id(identifier), | ||
|
|
||
| // TODO: We currently use `try_expression_scope_id` here as a hotfix for [1]. | ||
| // Revert this to use `expression_scope_id` once a proper fix is in place. |
Contributor
There was a problem hiding this comment.
(Not a request to actually change this comment, but) I'm not convinced we should necessarily ever change this back to using expression_scope_id, regardless of what other fixes are made.
Contributor
Author
There was a problem hiding this comment.
Admittedly, I didn't follow the full discussion in #18441, so I was potentially overly-cautious here. I opened this PR mainly because I can't work without the ty playground anymore 🙃.
carljm
added a commit
to mtshiba/ruff
that referenced
this pull request
Jun 4, 2025
* main: [ty] Only consider a type `T` a subtype of a protocol `P` if all of `P`'s members are fully bound on `T` (astral-sh#18466) [ty] Exclude members starting with `_abc_` from a protocol interface (astral-sh#18467) [ty] Add subdiagnostic suggestion to `unresolved-reference` diagnostic when variable exists on `self` (astral-sh#18444) [ty] IDE: only provide declarations and bindings as completions (astral-sh#18456) [ty] ty_ide: Hotfix for `expression_scope_id` panics (astral-sh#18455) [ty] Improve docs for Class{Literal,Type}::instance_member (astral-sh#18454) [ty] Add meta-type tests for legavy TypeVars (astral-sh#18453) update to salsa that doesn't panic silently on cycles (astral-sh#18450)
BurntSushi
added a commit
that referenced
this pull request
Sep 17, 2025
BurntSushi
added a commit
that referenced
this pull request
Sep 17, 2025
BurntSushi
added a commit
that referenced
this pull request
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement a hotfix for the playground/LSP crashes related to missing
expression_scope_ids.relates to: astral-sh/ty#572
Test Plan